Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-16036 replace basic_get innids with sql builder #6488

Merged
merged 31 commits into from
Aug 13, 2015

Conversation

eileenmcnaughton
Copy link
Contributor

johanv and others added 30 commits August 13, 2015 11:39
This test fails.

----------------------------------------
* CRM-16036: API: searching events on custom fields does not work
  https://issues.civicrm.org/jira/browse/CRM-16036
One to work around the issue. Still lots of TODOs.
If you filter on a custom field using the api, the custom
get_using_query_object is used. And it still ignores the
custom fields :-)
civicrm_api3_get_using_query_object_simple now allows filtering on custom fields.
The fields to select are still hard coded. But this is work
in progress.
Because that seems to be more intuitive.
Not sure whether this is really necessary. But I just did to
be safe.
I changed _civicrm_api3_basic_get so that it calls my hack
(_civicrm_api3_get_using_query_object_simple) whenever a
custom field is used in $params. In all other cases, the API
behaves as before.

----------------------------------------
* CRM-16036: API: searching on custom fields does not work
  https://issues.civicrm.org/jira/browse/CRM-16036
Thank you @colemanw.

----------------------------------------
* CRM-16036: API: searching on custom fields does not work
  https://issues.civicrm.org/jira/browse/CRM-16036
Here is a unit test.

----------------------------------------
* CRM-16036: API: searching on custom fields does not work
  https://issues.civicrm.org/jira/browse/CRM-16036
----------------------------------------
* CRM-16036: API: searching on custom fields does not work
  https://issues.civicrm.org/jira/browse/CRM-16036
When using a custom field as param for the API, chaining
didn't work as it should. This is a fix.

I have a unit test for this as well, but it depends on a fix for
CRM-16168, so if I add it here, it will break anyway.

I will document this in the issue itself.

----------------------------------------
* CRM-16036: API: searching on custom fields does not work
  https://issues.civicrm.org/jira/browse/CRM-16036
* CRM-16168: Chained call event-loc block returns an error if no loc block exists.
  https://issues.civicrm.org/jira/browse/CRM-16168
----------------------------------------
* CRM-16036: API: searching on custom fields does not work
  https://issues.civicrm.org/jira/browse/CRM-16036
…ter & duplicates it, maintaining both = less good
@kurund kurund added the 4.7 label Aug 13, 2015
eileenmcnaughton added a commit that referenced this pull request Aug 13, 2015
CRM-16036 replace basic_get innids with sql builder
@eileenmcnaughton eileenmcnaughton merged commit b020deb into civicrm:master Aug 13, 2015
@eileenmcnaughton eileenmcnaughton deleted the CRM-16036-master branch August 13, 2015 02:53
@eileenmcnaughton eileenmcnaughton mentioned this pull request Aug 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants