-
-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRM-16036 replace basic_get innids with sql builder #6488
Merged
eileenmcnaughton
merged 31 commits into
civicrm:master
from
eileenmcnaughton:CRM-16036-master
Aug 13, 2015
Merged
CRM-16036 replace basic_get innids with sql builder #6488
eileenmcnaughton
merged 31 commits into
civicrm:master
from
eileenmcnaughton:CRM-16036-master
Aug 13, 2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eileenmcnaughton
commented
Aug 13, 2015
- CRM-16036: API: searching on custom fields only works for contacts
This test fails. ---------------------------------------- * CRM-16036: API: searching events on custom fields does not work https://issues.civicrm.org/jira/browse/CRM-16036
One to work around the issue. Still lots of TODOs. If you filter on a custom field using the api, the custom get_using_query_object is used. And it still ignores the custom fields :-)
civicrm_api3_get_using_query_object_simple now allows filtering on custom fields.
The fields to select are still hard coded. But this is work in progress.
Because that seems to be more intuitive.
Not sure whether this is really necessary. But I just did to be safe.
I changed _civicrm_api3_basic_get so that it calls my hack (_civicrm_api3_get_using_query_object_simple) whenever a custom field is used in $params. In all other cases, the API behaves as before. ---------------------------------------- * CRM-16036: API: searching on custom fields does not work https://issues.civicrm.org/jira/browse/CRM-16036
Thank you @colemanw. ---------------------------------------- * CRM-16036: API: searching on custom fields does not work https://issues.civicrm.org/jira/browse/CRM-16036
Here is a unit test. ---------------------------------------- * CRM-16036: API: searching on custom fields does not work https://issues.civicrm.org/jira/browse/CRM-16036
---------------------------------------- * CRM-16036: API: searching on custom fields does not work https://issues.civicrm.org/jira/browse/CRM-16036
When using a custom field as param for the API, chaining didn't work as it should. This is a fix. I have a unit test for this as well, but it depends on a fix for CRM-16168, so if I add it here, it will break anyway. I will document this in the issue itself. ---------------------------------------- * CRM-16036: API: searching on custom fields does not work https://issues.civicrm.org/jira/browse/CRM-16036 * CRM-16168: Chained call event-loc block returns an error if no loc block exists. https://issues.civicrm.org/jira/browse/CRM-16168
---------------------------------------- * CRM-16036: API: searching on custom fields does not work https://issues.civicrm.org/jira/browse/CRM-16036
…orrect results for the non-deprecated api
…ter & duplicates it, maintaining both = less good
eileenmcnaughton
added a commit
that referenced
this pull request
Aug 13, 2015
CRM-16036 replace basic_get innids with sql builder
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.